Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106714: Fix test_capi to not write a coredump #107007

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 22, 2023

test_capi: Fix test_no_FatalError_infinite_loop() to no longer write a coredump, by using test.support.SuppressCrashReport.

test_capi: Fix test_no_FatalError_infinite_loop() to no longer write
a coredump, by using test.support.SuppressCrashReport.
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 22, 2023
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 22, 2023
@vstinner vstinner enabled auto-merge (squash) July 22, 2023 12:00
@vstinner vstinner merged commit 4a1026d into python:main Jul 22, 2023
26 checks passed
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4a1026d7647c084b0dc80dd49163d16ba12a2e55 3.11

@bedevere-bot
Copy link

GH-107009 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
test_capi: Fix test_no_FatalError_infinite_loop() to no longer write
a coredump, by using test.support.SuppressCrashReport.
(cherry picked from commit 4a1026d)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner deleted the test_capi_coredump branch July 22, 2023 12:28
@vstinner vstinner removed the needs backport to 3.11 only security fixes label Jul 22, 2023
@vstinner
Copy link
Member Author

Python 3.11 is not affected: #106714 (comment)

vstinner added a commit that referenced this pull request Jul 22, 2023
…107009)

gh-106714: Fix test_capi to not write a coredump (GH-107007)

test_capi: Fix test_no_FatalError_infinite_loop() to no longer write
a coredump, by using test.support.SuppressCrashReport.
(cherry picked from commit 4a1026d)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants