-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
Datamodel: Add headings to the standard type hierarchy #108146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datamodel: Add headings to the standard type hierarchy #108146
Conversation
Fine by me! |
Hm, it looks like the two intrinsic set types should also be a definition list. Also, I find it strange that "Notes on using __slots__" is a sub-sub-sub-section. Would it not fit better as a bullet list in the parent sub-sub-section? |
No strong opinion here, so made them definition lists.
A sub-sub-sub-sub-section, even! I'll open a new PR for Notes on using slots, this one is only intended to look at section 3.2 (the standard type hierarchy). Update: see #108400. A |
@hugovk, are you ok with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, no strong opinion, but more linkable things in long pages is helpful. Thanks!
I'd prefer this PR to only restructure the file but keep the content unchanged :) |
Thanks @AA-Turner for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @AA-Turner and @erlend-aasland, I could not cleanly backport this to |
GH-108477 is a backport of this pull request to the 3.12 branch. |
Dedent content according to the new layout. (cherry picked from commit 2b7bff0) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Thanks @AA-Turner for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry @AA-Turner and @erlend-aasland, I had trouble checking out the |
Thanks @AA-Turner for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry @AA-Turner and @erlend-aasland, I had trouble checking out the |
…GH-108146) Dedent content according to the new layout.. (cherry picked from commit 2b7bff0) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-108484 is a backport of this pull request to the 3.11 branch. |
I was looking to resolve reference warnings in the datamodel documentation, and noticed that the entire The standard type hierarchy section is comprised of definition lists. This makes it fairly hard to navigate via the sidebar, with three levels of nested indentation.
Each commit in this PR is a discrete step:
This is a preparatory PR for future improvements, but I think one that stands alone as an improvement to navigation. I imagine backports will need to be done manually due to changes in the datamodel between 3.11-3.13, happy to handle them.
A
📚 Documentation preview 📚: https://cpython-previews--108146.org.readthedocs.build/en/108146/reference/datamodel.html