gh-107902: Don't test setting suid/sgid on systems that don't support them #108368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@furkanonder, could you check this on the Manjaro aarch64 system? |
ethanfurman
reviewed
Aug 23, 2023
It looks good to me, the tests are not failing anymore. |
furkanonder
approved these changes
Aug 24, 2023
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Oct 10, 2024
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Oct 16, 2024
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2024
…ystems that don't support them (GH-108368) (GH-109697) (#125255) * gh-107902: Don't test setting suid/sgid on systems that don't support them (GH-108368) * gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. --------- Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 22, 2024
…/sticky on systems that don't support them (pythonGH-108368) (pythonGH-109697) (pythonGH-125255) * pythongh-107902: Don't test setting suid/sgid on systems that don't support them (pythonGH-108368) * pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pythonGH-109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. --------- (cherry picked from commit 6bbaab8) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
ambv
pushed a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.