[3.12] gh-108682: [Enum] raise TypeError if super().__new__ called in custom __new__ (GH-108704) #108733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…custom __new__ (pythonGH-108704) When overriding the `__new__` method of an enum, the underlying data type should be created directly; i.e. . member = object.__new__(cls) member = int.__new__(cls, value) member = str.__new__(cls, value) Calling `super().__new__()` finds the lookup version of `Enum.__new__`, and will now raise an exception when detected. (cherry picked from commit d48760b) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
This was referenced Aug 31, 2023
bedevere-bot
added
type-bug
ethanfurman
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When overriding the
__new__method of an enum, the underlying data type should be created directly; i.e. .Calling
super().__new__()finds the lookup version ofEnum.__new__, and will now raise an exception when detected.(cherry picked from commit d48760b)
Co-authored-by: Ethan Furman ethan@stoneleaf.us
📚 Documentation preview 📚: https://cpython-previews--108733.org.readthedocs.build/