[3.11] gh-108682: [Enum] raise TypeError if super().new called in custom new (GH-108704) #108739

ethanfurman · 2023-08-31T22:33:01Z

When overriding the __new__ method of an enum, the underlying data type should be created directly; i.e. .

member = object.__new__(cls)
member = int.__new__(cls, value)
member = str.__new__(cls, value)

Calling super().__new__() finds the lookup version of Enum.__new__, and will now raise an exception when detected.

(cherry picked from commit d48760b)

Issue: 3.11.5 Regression: Flags with custom __new__ can't be iterated #108682

📚 Documentation preview 📚: https://cpython-previews--108739.org.readthedocs.build/

…custom __new__ (pythonGH-108704) When overriding the `__new__` method of an enum, the underlying data type should be created directly; i.e. . member = object.__new__(cls) member = int.__new__(cls, value) member = str.__new__(cls, value) Calling `super().__new__()` finds the lookup version of `Enum.__new__`, and will now raise an exception when detected. (cherry picked from commit d48760b)

ethanfurman added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory 3.11 only security fixes labels Aug 31, 2023

ethanfurman self-assigned this Aug 31, 2023

This was referenced Aug 31, 2023

3.11.5 Regression: Flags with custom __new__ can't be iterated #108682

Closed

gh-108682: [Enum] raise TypeError if super().__new__ called in custom __new__ #108704

Merged

bedevere-bot added the awaiting core review label Aug 31, 2023

ethanfurman merged commit effa2ec into python:3.11 Sep 8, 2023

bedevere-bot removed the awaiting core review label Sep 8, 2023

ethanfurman deleted the backport-d48760b-3.11 branch September 8, 2023 01:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[3.11] gh-108682: [Enum] raise TypeError if super().new called in custom new (GH-108704) #108739

[3.11] gh-108682: [Enum] raise TypeError if super().new called in custom new (GH-108704) #108739

Uh oh!

ethanfurman commented Aug 31, 2023 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Uh oh!

[3.11] gh-108682: [Enum] raise TypeError if super().__new__ called in custom __new__ (GH-108704) #108739

[3.11] gh-108682: [Enum] raise TypeError if super().__new__ called in custom __new__ (GH-108704) #108739

Uh oh!

Conversation

ethanfurman commented Aug 31, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

[3.11] gh-108682: [Enum] raise TypeError if super().new called in custom new (GH-108704) #108739

[3.11] gh-108682: [Enum] raise TypeError if super().new called in custom new (GH-108704) #108739

ethanfurman commented Aug 31, 2023 •

edited by github-actions bot

Loading