gh-110383: Explained which error message is generated when there is an unhandled exception #111574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
Unique-Usman
changed the title
gh-110383: Explained which error message is generated when there is an unhandled exception 
|
@hugovk @CAM-Gerlach help review this. |
|
Which one is this from the list at #110383? |
hugovk
reviewed
Nov 19, 2023
hugovk
added
needs backport to 3.11
Explained what happened when there is no handler for an exception i.e unhandled exception. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
Thank you! |
|
Thanks @Unique-Usman for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2023
…e is an unhandled exception (pythonGH-111574) (cherry picked from commit a6d25de) Co-authored-by: Unique-Usman <86585626+Unique-Usman@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2023
…e is an unhandled exception (pythonGH-111574) (cherry picked from commit a6d25de) Co-authored-by: Unique-Usman <86585626+Unique-Usman@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
GH-112264 is a backport of this pull request to the 3.12 branch. |
|
GH-112265 is a backport of this pull request to the 3.11 branch. |
|
It makes sense like this, as it has been clearly mentioned that it is an unhandled exception. Thank you @hugovk |
hugovk
added a commit
that referenced
this pull request
Nov 19, 2023
hugovk
added a commit
that referenced
this pull request
Nov 19, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…e is an unhandled exception (python#111574) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line "with a message as shown above" is ambiguous as an error message has also came after the intended error message. So, I clealy explain which error message is generated and linked the message to where it is being described.
📚 Documentation preview 📚: https://cpython-previews--111574.org.readthedocs.build/