gh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set #113378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set.
sobolevn
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
This works for me, thank you!
~/Desktop/cpython2 gh-109989 ✔
» echo $PYTHONIOENCODING
UTF-8
~/Desktop/cpython2 gh-109989 ✔
» ./python.exe Lib/test/test_c_locale_coercion.py
AVAILABLE_TARGETS = ['UTF-8']
EXPECTED_C_LOCALE_EQUIVALENTS = ['C', 'invalid.ascii']
EXPECTED_C_LOCALE_STREAM_ENCODING = 'ascii'
EXPECTED_C_LOCALE_FS_ENCODING = 'utf-8'
EXPECT_COERCION_IN_DEFAULT_LOCALE = True
_C_UTF8_LOCALES = ('C.UTF-8', 'C.utf8', 'UTF-8')
_check_nl_langinfo_CODESET = False
........
----------------------------------------------------------------------
Ran 8 tests in 0.844s
OK
~/Desktop/cpython2 gh-109989 ✔
» ./python.exe -m test test_c_locale_coercion
Using random seed: 4095422379
0:00:00 load avg: 4.31 Run 1 test sequentially
0:00:00 load avg: 4.31 [1/1] test_c_locale_coercion
== Tests result: SUCCESS ==
1 test OK.
Total duration: 849 ms
Total tests: run=8
Total test files: run=1/1
Result: SUCCESS
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ronaldoussoren
added
needs backport to 3.11
serhiy-storchaka
approved these changes
Dec 22, 2023
|
Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-113398 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 22, 2023
…set (pythonGH-113378) * pythongh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set. (cherry picked from commit 5f665e9) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 22, 2023
…set (pythonGH-113378) * pythongh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set. (cherry picked from commit 5f665e9) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-113399 is a backport of this pull request to the 3.11 branch. |
ronaldoussoren
added a commit
that referenced
this pull request
Dec 23, 2023
… set (GH-113378) (#113398) gh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set (GH-113378) * gh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set. (cherry picked from commit 5f665e9) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ronaldoussoren
added a commit
that referenced
this pull request
Dec 23, 2023
… set (GH-113378) (#113399) gh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set (GH-113378) * gh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set. (cherry picked from commit 5f665e9) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
…set (python#113378) * pythongh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set. Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…set (python#113378) * pythongh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set. Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…set (python#113378) * pythongh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set. Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…set (python#113378) * pythongh-109989: Fix test_c_locale_coercion when PYTHONIOENCODING is set This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING. Also add a test that explicitly checks what happens when PYTHONIOENCODING is set. Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the existing tests when PYTHONIOENCODING is set by unsetting PYTHONIOENCODING.
Also add a test that explicitly checks what happens when PYTHONIOENCODING is set.
test_c_locale_coercionfails on macos Sonoma #109989