Skip to content

gh-114241: Fix retrieving files in the ftplib CLI #114242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2024
Merged

gh-114241: Fix retrieving files in the ftplib CLI #114242

merged 2 commits into from
Jan 21, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 18, 2024 •
edited by bedevere-app bot
Loading

Also improve its help.

@bedevere-app bedevere-app bot mentioned this pull request Jan 18, 2024
Closed
@tom93 tom93 mentioned this pull request Jan 18, 2024
Closed
@serhiy-storchaka
Fix few more errors.
4353cb4 
* Add a newline after writing warnings to stderr.
* Fix a TypeError if the netrc file doesn't contain a host/default entry.
erlend-aasland
erlend-aasland approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; tested locally with vsftpd. I think a NEWS entry for this bugfix would be fine.

@serhiy-storchaka
Copy link
Member Author

It does not officially exist. A NEWS entry will only confuse users.

@erlend-aasland
Copy link
Contributor

It does not officially exist. A NEWS entry will only confuse users.

This is not correct; it does officially exist: https://docs.python.org/3/library/cmdline.html

@serhiy-storchaka
Copy link
Member Author

Then we should fix this list.

@serhiy-storchaka serhiy-storchaka merged commit 42d72b2 into python:main Jan 21, 2024
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@serhiy-storchaka serhiy-storchaka deleted the ftplib-cli branch January 21, 2024 20:16
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2024
@serhiy-storchaka @miss-islington
pythongh-114241: Fix and improve the ftplib CLI (pythonGH-114242)
bc68327 
* Fix writing the retrieved binary file to stdout.
* Add a newline after writing warnings to stderr.
* Fix a TypeError if the netrc file doesn't contain a host/default entry.
* Improve the usage message.
(cherry picked from commit 42d72b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2024
@serhiy-storchaka @miss-islington
pythongh-114241: Fix and improve the ftplib CLI (pythonGH-114242)
36a6282 
* Fix writing the retrieved binary file to stdout.
* Add a newline after writing warnings to stderr.
* Fix a TypeError if the netrc file doesn't contain a host/default entry.
* Improve the usage message.
(cherry picked from commit 42d72b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 21, 2024

GH-114404 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 21, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 21, 2024

GH-114405 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 21, 2024
serhiy-storchaka added a commit that referenced this pull request Jan 21, 2024
@miss-islington @serhiy-storchaka
[3.11] gh-114241: Fix and improve the ftplib CLI (GH-114242) (GH-114405)
58c93d8 
* Fix writing the retrieved binary file to stdout.
* Add a newline after writing warnings to stderr.
* Fix a TypeError if the netrc file doesn't contain a host/default entry.
* Improve the usage message.
(cherry picked from commit 42d72b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 21, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-114241: Fix and improve the ftplib CLI (GH-114242) (GH-114404)
4c42d98 
* Fix writing the retrieved binary file to stdout.
* Add a newline after writing warnings to stderr.
* Fix a TypeError if the netrc file doesn't contain a host/default entry.
* Improve the usage message.
(cherry picked from commit 42d72b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@serhiy-storchaka @kulikjak
pythongh-114241: Fix and improve the ftplib CLI (pythonGH-114242)
3e23db9 
* Fix writing the retrieved binary file to stdout.
* Add a newline after writing warnings to stderr.
* Fix a TypeError if the netrc file doesn't contain a host/default entry.
* Improve the usage message.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-114241: Fix and improve the ftplib CLI (pythonGH-114242)
45a30b5 
* Fix writing the retrieved binary file to stdout.
* Add a newline after writing warnings to stderr.
* Fix a TypeError if the netrc file doesn't contain a host/default entry.
* Improve the usage message.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-114241: Fix and improve the ftplib CLI (pythonGH-114242)
97bb7e8 
* Fix writing the retrieved binary file to stdout.
* Add a newline after writing warnings to stderr.
* Fix a TypeError if the netrc file doesn't contain a host/default entry.
* Improve the usage message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @erlend-aasland