Skip to content

gh-114414: Check for NULL after PyType_GetModuleByDef in _threadmodule #114415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2024
Merged

gh-114414: Check for NULL after PyType_GetModuleByDef in _threadmodule #114415

merged 2 commits into from
Jan 22, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 22, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from encukou January 22, 2024 08:39
@bedevere-app bedevere-app bot mentioned this pull request Jan 22, 2024
Closed
aisk
aisk reviewed Jan 22, 2024
View reviewed changes
@erlend-aasland erlend-aasland merged commit d1b031c into python:main Jan 22, 2024
@erlend-aasland
Copy link
Contributor

Backport to 3.12? Perhaps also 3.11? I don't remember when this module was isolated.

@encukou
Copy link
Member

encukou commented Jan 22, 2024

It's not a bugfix.
Practically, you still get a crash rather soon; the assert adds a nice error message in debug builds. IMO, that will mainly be useful if this code changes in the future.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@sobolevn @kulikjak
pythongh-114414: Assert PyType_GetModuleByDef result in _threadmodule (…
fbfbd15 
…python#114415)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-114414: Assert PyType_GetModuleByDef result in _threadmodule (…
a27e46a 
…python#114415)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-114414: Assert PyType_GetModuleByDef result in _threadmodule (…
532b409 
…python#114415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments

@encukou encukou encukou approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @erlend-aasland @encukou @aisk