Skip to content

gh-114100: Remove superfluous writing to fd 1 in test_pty #114647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2024
Merged

gh-114100: Remove superfluous writing to fd 1 in test_pty #114647

merged 1 commit into from
Jan 27, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 27, 2024 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 27, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jan 27, 2024
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 27, 2024
Closed
Eclips4
Eclips4 approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This changes makes sense to me, because
1: We do not see output of the test now.
2: We make sure that right data is written to fd.

Closing #114645 because this approach is better.
Thanks Serhiy.

@serhiy-storchaka serhiy-storchaka merged commit 7a47054 into python:main Jan 27, 2024
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test_pty-test_spawn_doesnt_hang branch January 27, 2024 16:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
@serhiy-storchaka @miss-islington
pythongh-114100: Remove superfluous writing to fd 1 in test_pty (pyth…
5e81f8d 
…onGH-114647)

(cherry picked from commit 7a47054)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
@serhiy-storchaka @miss-islington
pythongh-114100: Remove superfluous writing to fd 1 in test_pty (pyth…
46a884a 
…onGH-114647)

(cherry picked from commit 7a47054)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2024

GH-114655 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 27, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2024

GH-114656 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 27, 2024
serhiy-storchaka added a commit that referenced this pull request Jan 27, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-114100: Remove superfluous writing to fd 1 in test_pty (GH-…
205ac6e 
…114647) (GH-114655)

(cherry picked from commit 7a47054)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 27, 2024
@miss-islington @serhiy-storchaka
[3.11] gh-114100: Remove superfluous writing to fd 1 in test_pty (GH-…
3a3e873 
…114647) (GH-114656)

(cherry picked from commit 7a47054)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-114100: Remove superfluous writing to fd 1 in test_pty (pyth…
55401d8 
…onGH-114647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @Eclips4