gh-115231: fill __module__ for built-in staticmethods

[skirpichev]

• Issue: Empty __module__ attribute for built-in static methods #115231

[sobolevn]

This might theoretically return NULL and raise AttributeError.

[skirpichev]

Hmm, thanks. Probably we could just clear the error indicator on mod == NULL.

[sobolevn]

Also take a look at GetOptionalAttr

[skirpichev]

I think we want ignore here not just AttributeError's. I did similar fix for class methods and got a failure in the test.test_types.UnionTests.test_or_type_operator_with_bad_module().

[serhiy-storchaka]

It is better to use type_module() for consistency with the rest of this file. It will not give a surprise if Exceptions other than AttributeError should not be ignored.

[skirpichev]

See also #82062: we could fix that issue in a similar approach, using __objclass__.__module__ to set the __module__ attribute. Right now for built-in instance methods its missing (c.f. pure-python classes):

>>> int.to_bytes.__module__
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'method_descriptor' object has no attribute '__module__'. Did you mean: '__reduce__'?

[skirpichev]

CC @serhiy-storchaka

[serhiy-storchaka]

It is better to use type_module() for consistency with the rest of this file. It will not give a surprise if Exceptions other than AttributeError should not be ignored.