Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-117546: Fix symlink resolution in os.path.realpath('loop/../link') #117568

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Apr 5, 2024

Continue resolving symlink targets after encountering a symlink loop, which matches coreutils realpath behaviour. POSIX-only fix; Windows works differently.


📚 Documentation preview 📚: https://cpython-previews--117568.org.readthedocs.build/

…/link')`

Continue resolving symlink targets after encountering a symlink loop, which
matches coreutils `realpath` behaviour.
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

#117562 includes a similar change.

@barneygale
Copy link
Contributor Author

Thank you for the review

@barneygale barneygale merged commit 630df37 into python:main Apr 10, 2024
37 checks passed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…/link')` (python#117568)

Continue resolving symlink targets after encountering a symlink loop, which
matches coreutils `realpath` behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants