Skip to content

gh-117683: Fix test_free_different_thread failures with GIL disabled #117685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

gh-117683: Fix test_free_different_thread failures with GIL disabled #117685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63f23d5
gh-117683: Fix test_free_different_thread failures with GIL disabled
colesbury Apr 9, 2024
b775561
LAST_FREED may have a non-None value from previous tests
colesbury Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Lib/test/test_code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
ctypes = None
from test.support import (cpython_only,
check_impl_detail, requires_debug_ranges,
gc_collect)
gc_collect, Py_GIL_DISABLED)
from test.support.script_helper import assert_python_ok
from test.support import threading_helper, import_helper
from test.support.bytecode_helper import instructions_with_positions
Expand Down Expand Up @@ -865,7 +865,11 @@ def __init__(self, f, test):
def run(self):
del self.f
gc_collect()
self.test.assertEqual(LAST_FREED, 500)
# gh-117683: In the free-threaded build, the code object's
# destructor may still be running concurrently in the main
# thread.
if not Py_GIL_DISABLED:
self.test.assertEqual(LAST_FREED, 500)

SetExtra(f.__code__, FREE_INDEX, ctypes.c_voidp(500))
tt = ThreadTest(f, self)
Expand Down