Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118658: Return consistent types from get_un/verified_chain in SSLObject and SSLSocket #118669

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

gh-118658: Return consistent types from get_un/verified_chain in SSLObject and SSLSocket #118669

wants to merge 18 commits into from

Conversation

matiuszka
Copy link
Contributor

@matiuszka matiuszka commented May 6, 2024 •
edited by bedevere-app bot

Fixses inconsistent return types between SSLObject and SSLSocket as described in gh-118656

@bedevere-app bedevere-app bot mentioned this pull request May 6, 2024
Open
@matiuszka
Copy link
Contributor Author

I restored my old branch from which I created the original PR #109113. There is one file missing about NEWS, I am not sure if that was removed on purpose or not.

sethmlarson
sethmlarson reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, since these methods are now documented would it make sense to have a test case?

@matiuszka
Copy link
Contributor Author

Seems good to me, since these methods are now documented would it make sense to have a test case?

Why not, it will not hurt. I will add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matiuszka @sethmlarson @gpshead