Skip to content

[3.5] bpo-34791: xml package obeys ignore env flags (GH-9544) #11871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2019
Merged

[3.5] bpo-34791: xml package obeys ignore env flags (GH-9544) #11871

merged 2 commits into from
Feb 26, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

The xml.sax and xml.dom.domreg modules now obey
sys.flags.ignore_environment.

Signed-off-by: Christian Heimes christian@python.org

(cherry picked from commit 223e501)

https://bugs.python.org/issue34791

@tiran @vstinner
bpo-34791: xml package obeys ignore env flags (GH-9544)
0be7334 
The xml.sax and xml.dom.domreg modules now obey
sys.flags.ignore_environment.

Signed-off-by: Christian Heimes <christian@python.org>

(cherry picked from commit 223e501)
@bedevere-bot bedevere-bot added the type-security A security issue label Feb 15, 2019
@matrixise
Copy link
Member

@vstinner LGTM

@vstinner
Copy link
Member Author

@larryhastings: Would you mind to merge this security fix as well?

@larryhastings larryhastings merged commit 7cd08cf into python:3.5 Feb 26, 2019
@bedevere-bot
Copy link

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Contributor

Thanks for the backport! At long last the xml package will obey human commands.

@vstinner vstinner deleted the xml_ignore_env35 branch April 29, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vstinner @matrixise @bedevere-bot @larryhastings @gpshead @the-knights-who-say-ni @tiran