Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117657: Acquire a critical section around SemLock.__{enter,exit}__ #118812

Merged
merged 1 commit into from
May 9, 2024

Conversation

mpage
Copy link
Contributor

@mpage mpage commented May 9, 2024

These methods are purely wrappers around Semlock.{acquire,release}, which expect a critical section to be held.

Sample race reported by TSAN.

These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
@mpage mpage added the skip news label May 9, 2024
@mpage mpage requested a review from colesbury May 9, 2024 00:08
@mpage mpage marked this pull request as ready for review May 9, 2024 00:48
@mpage mpage requested a review from gpshead as a code owner May 9, 2024 00:48
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label May 9, 2024
@colesbury colesbury merged commit c30d8e5 into python:main May 9, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @mpage for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
…exit}__` (pythonGH-118812)

These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
(cherry picked from commit c30d8e5)

Co-authored-by: mpage <mpage@meta.com>
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

GH-118856 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
colesbury pushed a commit that referenced this pull request May 9, 2024
…,exit}__` (GH-118812) (#118856)

These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
(cherry picked from commit c30d8e5)

Co-authored-by: mpage <mpage@meta.com>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
…exit}__` (python#118812)

These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants