Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33944: Add site.py site-packages tracing in verbose mode #12110

Open
wants to merge 5 commits into
base: master
from

Conversation

@native-api
Copy link
Contributor

commented Mar 1, 2019

@native-api native-api force-pushed the native-api:site_trace branch from c3421c6 to 5fecd83 Mar 1, 2019

Lib/site.py Outdated Show resolved Hide resolved
Lib/site.py Outdated Show resolved Hide resolved
methane and others added 2 commits Mar 2, 2019
code style fix
Co-Authored-By: native-api <ivan_pozdeev@mail.ru>
use newer string formatting syntax
Co-Authored-By: native-api <ivan_pozdeev@mail.ru>
@methane

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

I didn't mean single place. I meant changing all % usages.

@native-api

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

@methane: I didn't mean single place. I meant changing all % usages.

Well, the suggested change feature commits exactly what you suggested (I don't actually know if I can change it at all), and I didn't look any further, trusting your review.
Could you please do the task to completion? There may be yet other small things to fix or something.

@methane

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

and I didn't look any further, trusting your review.

Please don't trust me as such. I hope contributors is not robot just applying suggested change. I hope contributors understand and grow up by review.

Could you please do the task to completion? There may be yet other small things to fix or something.

At a code level, looks good me.
But I'm not sure that adding more PYTHON* env vars is really good thing for this particular case...

Adding more and more envvar makes it harder to users read manual and find option they needed by their self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.