Skip to content

Duplicate test function in test_site #12140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2019
Merged

Duplicate test function in test_site #12140

merged 1 commit into from
Mar 3, 2019

Conversation

native-api
Copy link
Contributor

Pycharm caught this as "overriden method without use".

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Mar 2, 2019
@native-api native-api changed the title Removed duplicate test function Remove duplicate test function in test_site Mar 2, 2019
Mariatta
Mariatta reviewed Mar 2, 2019
View reviewed changes
@native-api native-api force-pushed the test_site_duplicate branch from 6db0fa0 to 15962e3 Compare March 3, 2019 00:59
@tirkarthi
Copy link
Member

I am not sure of test__getuserbase since extra underscore subtly looks same like test_getuserbase as noted in code comment. This was added with a8f8d5b . cc: @methane

methane
methane reviewed Mar 3, 2019
View reviewed changes
@native-api native-api changed the title Remove duplicate test function in test_site Duplicate test function in test_site Mar 3, 2019
@native-api
Copy link
Contributor Author

@methane et al
As per #12140 (comment) , it turns out, the first test_getuserbase tests _getuserbase while the second one tests getuserbase.
So it doesn't make sense to merge them.

@methane methane merged commit 45d8d24 into python:master Mar 3, 2019
@tirkarthi
Copy link
Member

tirkarthi commented Mar 3, 2019 •
edited
Loading

I guess this change can be backported since test is present in 3.7 too.

@miss-islington
Copy link
Contributor

Thanks @native-api for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2019
@native-api @miss-islington
fixed duplicated method name of test_getuserbase() (pythonGH-12140)
c619e25 
(cherry picked from commit 45d8d24)

Co-authored-by: native-api <ivan_pozdeev@mail.ru>
@bedevere-bot
Copy link

GH-12152 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 3, 2019
@miss-islington @native-api
fixed duplicated method name of test_getuserbase() (GH-12140)
f780443 
(cherry picked from commit 45d8d24)

Co-authored-by: native-api <ivan_pozdeev@mail.ru>
@native-api native-api deleted the test_site_duplicate branch March 15, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta left review comments

@methane methane methane approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@native-api @tirkarthi @miss-islington @bedevere-bot @methane @Mariatta @eamanu @the-knights-who-say-ni