Skip to content

Conversation

yi-jiayu
Copy link
Contributor

@yi-jiayu yi-jiayu commented Nov 5, 2024

This fixes an error in the example code in the curses tutorial illustrating the usage of the wrapper method which causes it to run through all iterations of the loop and error out before displaying anything on screen or waiting for user input.


📚 Documentation preview 📚: https://cpython-previews--126446.org.readthedocs.build/

This fixes an error in the example code  illustrating the usage of the `wrapper` method in the curses tutorial which causes it to run through all iterations of the loop and error out before displaying anything on screen or waiting for user input.
@ghost
Copy link

ghost commented Nov 5, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 5, 2024
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job spotting this!

@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@hugovk hugovk merged commit 5fbe23e into python:main Apr 10, 2025
43 of 44 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 10, 2025
@miss-islington-app
Copy link

Thanks @yi-jiayu for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2025
(cherry picked from commit 5fbe23e)

Co-authored-by: Jiayu Yi <yijiayu@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 10, 2025

GH-132362 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 10, 2025
hugovk pushed a commit that referenced this pull request Apr 10, 2025
Co-authored-by: Jiayu Yi <yijiayu@gmail.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants