GH-128682: Change a couple of functions to only steal references on success. #129132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… steal on success to avoid escaping
iritkatriel
approved these changes
Jan 21, 2025
|
I'd run the refleaks tests before merging. |
markshannon
added
the
🔨 test-with-refleak-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the tow functions
_PyTuple_FromStackRefStealand_PyList_FromStackRefStealto only steal references on success.This makes the functions non-escaping as they only close any references if they fail.
The resulting API is a bit awkward, but as it is used it so few places that shouldn't be a problem.