Skip to content

gh-130195: Remove unimplemented option from pygettext #130196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 18, 2025
Merged

gh-130195: Remove unimplemented option from pygettext #130196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d585bf5
Remove unimplemented option from pygettext
StanFromIreland Feb 16, 2025
2086fd4
Fix backticks
StanFromIreland Feb 16, 2025
e2dd8e3
Add warnings rather than remove
StanFromIreland Feb 16, 2025
74bfbf6
Delete dupe NEWS
StanFromIreland Feb 16, 2025
1f031dc
Make more explicit
StanFromIreland Feb 16, 2025
535d4bf
Apply Gudio's Suggestion
StanFromIreland Feb 16, 2025
616fe68
Add Depreciation warning and remove possible implementation
StanFromIreland Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tools-Demos/2025-02-16-19-00-00.gh-issue-130195.19274.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add warning messages when ``pygettext`` unimplemented ``-a/--extract-all`` option is called.
4 changes: 3 additions & 1 deletion Tools/i18n/pygettext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

-a
--extract-all
Extract all strings.
Deprecated: Not implemented and will be removed in a future version.

-d name
--default-domain=name
Expand Down Expand Up @@ -512,6 +512,8 @@ class Options:
if opt in ('-h', '--help'):
usage(0)
elif opt in ('-a', '--extract-all'):
print("DepreciationWarning: -a/--extract-all is not implemented and will be removed in a future version",
file=sys.stderr)
options.extractall = 1
elif opt in ('-d', '--default-domain'):
options.outfile = arg + '.pot'
Expand Down
Loading