Skip to content

gh-131852: Filter out POT-Creation-Date in msgfmt #131880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Mar 29, 2025

The snapshot json seems fine, no need for a new test IMO

@StanFromIreland
Copy link
Contributor Author

cc @tomasr8 @serhiy-storchaka

@StanFromIreland StanFromIreland marked this pull request as ready for review March 29, 2025 17:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@StanFromIreland
Copy link
Contributor Author

StanFromIreland commented Apr 5, 2025

Friendly ping @serhiy-storchaka :-)

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka merged commit ad6a032 into python:main Apr 5, 2025
39 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Apr 7, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2025
)

(cherry picked from commit ad6a032)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2025
)

(cherry picked from commit ad6a032)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 7, 2025

GH-132216 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 7, 2025
@bedevere-app
Copy link

bedevere-app bot commented Apr 7, 2025

GH-132217 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 7, 2025
serhiy-storchaka pushed a commit that referenced this pull request Apr 7, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…H-132216)

(cherry picked from commit ad6a032)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Apr 7, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…H-132217)

(cherry picked from commit ad6a032)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@StanFromIreland StanFromIreland deleted the pot-creation-date branch April 7, 2025 15:05
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants