gh-132354: document return value for asyncio.Task.cancel
#132374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixscherz
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
| @@ -0,0 +1 @@ | |||
| Document return value for :func:`asyncio.Task.cancel`. | |||
There was a problem hiding this comment.
Hi! Docs changes don't require a news entry. Cf. https://devguide.python.org/core-developers/committing/#updating-news-and-what-s-new-in-python
There was a problem hiding this comment.
Thank you! I removed it:)
This reverts commit e039f42.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
ZeroIntensity
added
docs
kumaraditya303
approved these changes
Apr 13, 2025
|
Thanks @felixscherz for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 13, 2025
…honGH-132374) (cherry picked from commit 64b066a) Co-authored-by: Felix Scherz <felixwscherz@gmail.com>
|
GH-132465 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is intended to resolve #132354. I documented the return value, similar to
asyncio.Future.cancel.📚 Documentation preview 📚: https://cpython-previews--132374.org.readthedocs.build/