Skip to content

gh-46236: Add Py_UNICODE_REPLACEMENT_CHARACTER doc #132706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

gh-46236: Add Py_UNICODE_REPLACEMENT_CHARACTER doc #132706

merged 3 commits into from
Apr 22, 2025

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Apr 18, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Apr 18, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Apr 18, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 18, 2025
Closed
33 tasks
@brianschubert
Copy link
Member

brianschubert commented Apr 18, 2025 •
edited
Loading

I notice that Py_UNICODE_REPLACEMENT_CHARACTER is under the "Internal API" section in Include/unicodeobject.h. Does that say anything about whether this should be documented?

brianschubert
brianschubert reviewed Apr 18, 2025
View reviewed changes
vstinner
vstinner reviewed Apr 22, 2025
View reviewed changes
vstinner
vstinner reviewed Apr 22, 2025
View reviewed changes
StanFromIreland and others added 2 commits April 22, 2025 10:45
@StanFromIreland @vstinner
Apply suggestions from code review
14c66f3 
Co-authored-by: Victor Stinner <vstinner@python.org>
@StanFromIreland
Move
92cb89b
vstinner
vstinner approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 5ffb894 into python:main Apr 22, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 22, 2025
@vstinner
Copy link
Member

Merged, thanks.

@StanFromIreland StanFromIreland deleted the Py_UNICODE_REPLACEMENT_CHARACTER branch April 22, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianschubert brianschubert brianschubert left review comments

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @brianschubert @vstinner