Skip to content

gh-133210: Fix test_inspect in --without-doc-strings mode #133250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

gh-133210: Fix test_inspect in --without-doc-strings mode #133250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions Lib/test/test_inspect/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3412,9 +3412,10 @@ def m1d(*args, **kwargs):
int))

def test_signature_on_classmethod(self):
self.assertEqual(self.signature(classmethod),
((('function', ..., ..., "positional_only"),),
...))
if not support.MISSING_C_DOCSTRINGS:
self.assertEqual(self.signature(classmethod),
((('function', ..., ..., "positional_only"),),
...))

class Test:
@classmethod
Expand All @@ -3434,9 +3435,10 @@ def foo(cls, arg1, *, arg2=1):
...))

def test_signature_on_staticmethod(self):
self.assertEqual(self.signature(staticmethod),
((('function', ..., ..., "positional_only"),),
...))
if not support.MISSING_C_DOCSTRINGS:
self.assertEqual(self.signature(staticmethod),
((('function', ..., ..., "positional_only"),),
...))

class Test:
@staticmethod
Expand Down Expand Up @@ -3954,9 +3956,10 @@ def __init__(self, b):

self.assertEqual(C(3), 8)
self.assertEqual(C(3, 7), 1)
# BUG: Returns '<Signature (b)>'
with self.assertRaises(AssertionError):
self.assertEqual(self.signature(C), self.signature((0).__pow__))
if not support.MISSING_C_DOCSTRINGS:
# BUG: Returns '<Signature (b)>'
with self.assertRaises(AssertionError):
self.assertEqual(self.signature(C), self.signature((0).__pow__))

class CM(type):
def __new__(mcls, name, bases, dct, *, foo=1):
Expand Down Expand Up @@ -4352,7 +4355,8 @@ class C:
__call__ = (2).__pow__

self.assertEqual(C()(3), 8)
self.assertEqual(self.signature(C()), self.signature((0).__pow__))
if not support.MISSING_C_DOCSTRINGS:
self.assertEqual(self.signature(C()), self.signature((0).__pow__))

with self.subTest('ClassMethodDescriptorType'):
class C(dict):
Expand All @@ -4361,7 +4365,8 @@ class C(dict):
res = C()([1, 2], 3)
self.assertEqual(res, {1: 3, 2: 3})
self.assertEqual(type(res), C)
self.assertEqual(self.signature(C()), self.signature(dict.fromkeys))
if not support.MISSING_C_DOCSTRINGS:
self.assertEqual(self.signature(C()), self.signature(dict.fromkeys))

with self.subTest('MethodDescriptorType'):
class C(str):
Expand All @@ -4375,7 +4380,8 @@ class C(int):
__call__ = int.__pow__

self.assertEqual(C(2)(3), 8)
self.assertEqual(self.signature(C()), self.signature((0).__pow__))
if not support.MISSING_C_DOCSTRINGS:
self.assertEqual(self.signature(C()), self.signature((0).__pow__))

with self.subTest('MemberDescriptorType'):
class C:
Expand All @@ -4393,7 +4399,8 @@ class C:
def __call__(self, *args, **kwargs):
pass

self.assertEqual(self.signature(C), ((), ...))
if not support.MISSING_C_DOCSTRINGS:
self.assertEqual(self.signature(C), ((), ...))
self.assertEqual(self.signature(C()),
((('a', ..., ..., "positional_only"),
('b', ..., ..., "positional_or_keyword"),
Expand Down
Loading