Skip to content

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented May 22, 2019

`Misc/NEWS <https://hg.python.org/cpython/file/3.2/Misc/NEWS>`_ file.
`Misc/NEWS
<https://github.com/python/cpython/blob/260a788767ff6dadd04ecf9e9e26b363ca28c8ae/Misc/NEWS>`_
file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original link https://hg.python.org/cpython/file/3.2/Misc/NEWS actually works (for now) and the replacement is not identical. Judging by the headings
original:

What's New in Python 3.2.7?

replacement:

What's New in Python 3.2?

Copy link
Contributor

@ashwinvis ashwinvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JulienPalard for fixing it, except for that python 3.2 link, it looks good.

@JulienPalard
Copy link
Member Author

On the https://hg.python.org/cpython/file/3.2/Misc/NEWS link I'm getting like 2/3 of 503, and 1/3 of 200.

@JulienPalard
Copy link
Member Author

But having a 200 on the old like allowed me to get the right commit \o/

@JulienPalard
Copy link
Member Author

@ashwinvis better now?

Copy link
Contributor

@ashwinvis ashwinvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1109,7 +1111,7 @@ For extension modules, consult :ref:`building-on-windows`.
MinGW gcc under Windows" or "Installing Python extension with distutils
and without Microsoft Visual C++" by Sébastien Sauvage, 2003

`MingW -- Python extensions <http://oldwiki.mingw.org/index.php/Python%20extensions>`_
`MingW -- Python extensions <http://www.mingw.org/wiki/FAQ#toc14>`_
by Trent Apted et al, 2007
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this credit since the document has changed (from https://web.archive.org/web/20160412131224/http://oldwiki.mingw.org/index.php/Python%20extensions) and now an FAQ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2019
(cherry picked from commit 7114c65)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot
Copy link

GH-13570 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 28, 2019
(cherry picked from commit 7114c65)

Co-authored-by: Julien Palard <julien@palard.fr>
@JulienPalard JulienPalard deleted the docs-404 branch June 16, 2019 14:03
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants