Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36710: Add tstate parameter in ceval.c #13547

Merged
merged 2 commits into from May 24, 2019
Merged

bpo-36710: Add tstate parameter in ceval.c #13547

merged 2 commits into from May 24, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 24, 2019 •
edited by bedevere-bot

  • Add pycore_pyerrors.h header file

  • New functions:

    • _PyErr_Clear()
    • _PyErr_Fetch()
    • _PyErr_Print()
    • _PyErr_Restore()
    • _PyErr_SetObject()
    • _PyErr_SetString()

  • Add 'tstate' parameter to _PyEval_AddPendingCall()

  • Fix a possible reference leak in _PyErr_Print() if exception
    is NULL

https://bugs.python.org/issue36710

@vstinner
bpo-36710: Add tstate parameter in ceval.c
7244735 
* Add pycore_pyerrors.h header file
* New functions:

  * _PyErr_Clear()
  * _PyErr_Fetch()
  * _PyErr_Print()
  * _PyErr_Restore()
  * _PyErr_SetObject()
  * _PyErr_SetString()

* Add 'tstate' parameter to _PyEval_AddPendingCall()
* Fix a possible reference leak in _PyErr_Print() if exception
  is NULL
@vstinner vstinner requested a review from a team as a code owner May 24, 2019 13:16
@vstinner
Cleanup
59d8685 
* prtrace(): tstate doesn't have to be const
* PyErr_BadInternalCall(): replace _PyErr_Format()
  with _PyErr_SetString()
@vstinner vstinner merged commit 438a12d into python:master May 24, 2019
@vstinner vstinner deleted the ceval_tstate branch May 24, 2019 15:01
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
bpo-36710: Add tstate parameter in ceval.c (pythonGH-13547)
36bbd57 
* Fix a possible reference leak in _PyErr_Print() if exception
  is NULL.
* PyErr_BadInternalCall(): replace PyErr_Format() with _PyErr_SetString().
* Add pycore_pyerrors.h header file.
* New functions:

  * _PyErr_Clear()
  * _PyErr_Fetch()
  * _PyErr_Print()
  * _PyErr_Restore()
  * _PyErr_SetObject()
  * _PyErr_SetString()

* Add 'tstate' parameter to _PyEval_AddPendingCall().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot