Skip to content

bpo-36919: make test_source_encoding.test_issue2301 implementation-independent #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2019
Merged

bpo-36919: make test_source_encoding.test_issue2301 implementation-independent #13639

merged 2 commits into from
Sep 11, 2019

Conversation

BCSharp
Copy link
Contributor

@BCSharp BCSharp commented May 28, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 28, 2019
jaraco
jaraco approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If this pattern is extended to more than one other case, it will be advisable to extract the behavior as a helper function that describes the justification for the behavior.

@jaraco jaraco merged commit b6643dc into python:master Sep 11, 2019
@bedevere-bot
Copy link

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @BCSharp for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@BCSharp @miss-islington
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
08fa0b3 
…dependent (pythonGH-13639)

* bpo-36919: make test_issue2301 implementation-independent
(cherry picked from commit b6643dc)

Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
@bedevere-bot
Copy link

GH-15952 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-15953 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@BCSharp @miss-islington
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
fc2d19a 
…dependent (pythonGH-13639)

* bpo-36919: make test_issue2301 implementation-independent
(cherry picked from commit b6643dc)

Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
jaraco pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @BCSharp @jaraco
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
c211939 
…dependent (GH-13639) (GH-15953)

* bpo-36919: make test_issue2301 implementation-independent
(cherry picked from commit b6643dc)

Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
jaraco pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @BCSharp @jaraco
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
42edfcf 
…dependent (GH-13639) (GH-15952)

* bpo-36919: make test_issue2301 implementation-independent
(cherry picked from commit b6643dc)

Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@BCSharp @DinoV
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
5cd02a2 
…dependent (python#13639)

* bpo-36919: make test_issue2301 implementation-independent
@BCSharp BCSharp mentioned this pull request Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco approved these changes

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BCSharp @bedevere-bot @miss-islington @jaraco @auvipy @the-knights-who-say-ni