Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36919: make test_source_encoding.test_issue2301 implementation-independent #13639

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@BCSharp
Copy link
Contributor

commented May 28, 2019

@auvipy
auvipy approved these changes May 29, 2019
@jaraco
jaraco approved these changes Sep 11, 2019
Copy link
Member

left a comment

Looks good. If this pattern is extended to more than one other case, it will be advisable to extract the behavior as a helper function that describes the justification for the behavior.

@jaraco jaraco merged commit b6643dc into python:master Sep 11, 2019

5 checks passed

Azure Pipelines PR #20190528.85 succeeded
Details
bedevere/issue-number Issue number 36919 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @BCSharp for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
…dependent (pythonGH-13639)

* bpo-36919: make test_issue2301 implementation-independent
(cherry picked from commit b6643dc)

Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15952 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15953 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
…dependent (pythonGH-13639)

* bpo-36919: make test_issue2301 implementation-independent
(cherry picked from commit b6643dc)

Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
jaraco added a commit that referenced this pull request Sep 11, 2019
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
…dependent (GH-13639) (GH-15953)

* bpo-36919: make test_issue2301 implementation-independent
(cherry picked from commit b6643dc)

Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
jaraco added a commit that referenced this pull request Sep 11, 2019
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
…dependent (GH-13639) (GH-15952)

* bpo-36919: make test_issue2301 implementation-independent
(cherry picked from commit b6643dc)

Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
…dependent (python#13639)

* bpo-36919: make test_issue2301 implementation-independent
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
bpo-36919: make test_source_encoding.test_issue2301 implementation-in…
…dependent (python#13639)

* bpo-36919: make test_issue2301 implementation-independent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.