Skip to content

[3.13] gh-136297: Fix hypothesis and subTest usage in test_zoneinfo_property.py (GH-136384) #136408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

[3.13] gh-136297: Fix hypothesis and subTest usage in test_zoneinfo_property.py (GH-136384) #136408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions Lib/test/test_zoneinfo/test_zoneinfo_property.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,23 +147,21 @@ def setUp(self):
def test_pickle_unpickle_cache(self, key):
zi = self.klass(key)
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.subTest(proto=proto):
pkl_str = pickle.dumps(zi, proto)
zi_rt = pickle.loads(pkl_str)
pkl_str = pickle.dumps(zi, proto)
zi_rt = pickle.loads(pkl_str)

self.assertIs(zi, zi_rt)
self.assertIs(zi, zi_rt)

@hypothesis.given(key=valid_keys())
@add_key_examples
def test_pickle_unpickle_no_cache(self, key):
zi = self.klass.no_cache(key)
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.subTest(proto=proto):
pkl_str = pickle.dumps(zi, proto)
zi_rt = pickle.loads(pkl_str)
pkl_str = pickle.dumps(zi, proto)
zi_rt = pickle.loads(pkl_str)

self.assertIsNot(zi, zi_rt)
self.assertEqual(str(zi), str(zi_rt))
self.assertIsNot(zi, zi_rt)
self.assertEqual(str(zi), str(zi_rt))

@hypothesis.given(key=valid_keys())
@add_key_examples
Expand Down
2 changes: 1 addition & 1 deletion Tools/requirements-hypothesis.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Requirements file for hypothesis that
# we use to run our property-based tests in CI.

hypothesis==6.111.2
hypothesis==6.135.26
Loading