Skip to content

gh-137025: Include python.worker.mjs in Emscripten Web Example #137236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

adqm
Copy link
Contributor

@adqm adqm commented Jul 30, 2025

While this patch does not fully address #137025, it should resolve the issue with python.worker.mjs not being included in the web_example directory.

@hoodmane, should I make a pass through the documentation-related suggestions from #137025 as well, or are you already on that?

Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adqm !

@hoodmane
Copy link
Contributor

should I make a pass through the documentation-related suggestions from #137025 as well

Please do!

@AA-Turner AA-Turner merged commit d5191ba into python:main Jul 31, 2025
48 checks passed
@AA-Turner
Copy link
Member

Does this need backporting?

A

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Refleaks 3.x (tier-3) has failed when building commit d5191ba.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1641/builds/681) and take a look at the build logs.
  4. Check if the failure is related to this commit (d5191ba) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1641/builds/681

Failed tests:

  • test_external_inspection

Failed subtests:

  • test_timerfd_ns_poll - test.test_os.TimerfdTests.test_timerfd_ns_poll
  • test_only_active_thread - test.test_external_inspection.TestGetStackTrace.test_only_active_thread

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_external_inspection.py", line 1246, in test_only_active_thread
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        len(gil_traces), 1, "Should have exactly one GIL holder"
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 0 != 1 : Should have exactly one GIL holder


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_os.py", line 4508, in test_timerfd_ns_poll
    self.check_timerfd_poll(True)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_os.py", line 4493, in check_timerfd_poll
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1

@hoodmane
Copy link
Contributor

Yeah, this is broken on the 3.14 branch so ideally it should be backported...

@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label Jul 31, 2025
@miss-islington-app
Copy link

Thanks @adqm for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2025
…Example (pythonGH-137236)

(cherry picked from commit d5191ba)

Co-authored-by: adam j hartz <hz@mit.edu>
@bedevere-app
Copy link

bedevere-app bot commented Jul 31, 2025

GH-137272 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants