-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
gh-137025: Include python.worker.mjs
in Emscripten Web Example
#137236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adqm !
Please do! |
Does this need backporting? A |
|
Yeah, this is broken on the 3.14 branch so ideally it should be backported... |
Thanks @adqm for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…Example (pythonGH-137236) (cherry picked from commit d5191ba) Co-authored-by: adam j hartz <hz@mit.edu>
GH-137272 is a backport of this pull request to the 3.14 branch. |
While this patch does not fully address #137025, it should resolve the issue with
python.worker.mjs
not being included in theweb_example
directory.@hoodmane, should I make a pass through the documentation-related suggestions from #137025 as well, or are you already on that?