Skip to content

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 18, 2025

(cherry picked from commit d8a9466)

Co-authored-by: Petr Viktorin encukou@gmail.com
Co-authored-by: Serhiy Storchaka storchaka@gmail.com

…et (pythonGH-30456)

(cherry picked from commit d8a9466)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@encukou
Copy link
Member

encukou commented Aug 18, 2025

This should be merged after #137906 (3.14.1).

@encukou encukou marked this pull request as draft August 18, 2025 14:57
@brettcannon brettcannon removed their request for review August 18, 2025 17:18
@Yhg1s
Copy link
Member

Yhg1s commented Sep 18, 2025

This should be merged after #137906 (3.14.1).
Why shouldn't this go into 3.13.8 (which is scheduled for around the same time as 3.14.0)?

@encukou
Copy link
Member

encukou commented Sep 18, 2025

Well, I'll generally backport in order. Do you want it in 3.13.8 but not 3.14.0?

@Yhg1s
Copy link
Member

Yhg1s commented Sep 18, 2025

Well, I'll generally backport in order. Do you want it in 3.13.8 but not 3.14.0?

Is there a reason not to have it in 3.13.8? :) I'm not sure why we wouldn't distribute the fix in 3.13 just because 3.14 has its own stabilization phase before the final release. I think I've done similar in 3.12 while 3.13.0 was in RC phase.

@Yhg1s
Copy link
Member

Yhg1s commented Sep 18, 2025

FWIW I double-checked with @hugovk (and also @gpshead chimed in) and the fact that it isn't in 3.14 yet is fine, it should still be fixed in 3.13 (and this isn't the only bugfix that would be in 3.13 but not 3.14, we have lots of other fixes pending in 3.14.)

@encukou encukou marked this pull request as ready for review September 18, 2025 13:34
@encukou
Copy link
Member

encukou commented Sep 18, 2025

Alright, I'll do that from now on :)

@encukou encukou changed the title [3.13] bpo-38735: Don't fail when importing from / with sys.pycache_prefix set (GH-30456) [3.13] gh-82916: Don't fail when importing from / with sys.pycache_prefix set (GH-30456) Sep 18, 2025
@encukou encukou merged commit 7de5d02 into python:3.13 Sep 18, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants