-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
gh-137481: fix test expectations on some platforms #138156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-137481: fix test expectations on some platforms #138156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I have some suggestions that reflect the original purpose of the test.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Thanks for the suggestions, it's fixed now. EDIT: and retested, just to be sure ;). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Thank you for your continued support of Python on Solaris.
Thank you for merging my changes 😉. |
The recently introduced
test_locale_calendar_long_weekday_names
expects abbreviated weekday names to be three characters long, which is not the case on Oracle Solaris. In case of"pt_PT.UTF-8"
locale:This makes the test work in such cases as well.