Skip to content

Conversation

kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Aug 26, 2025

The recently introduced test_locale_calendar_long_weekday_names expects abbreviated weekday names to be three characters long, which is not the case on Oracle Solaris. In case of "pt_PT.UTF-8" locale:

>>> import calendar
>>> print(list(calendar.day_name))
['segunda-feira', 'terça-feira', 'quarta-feira', 'quinta-feira', 'sexta-feira', 'sábado', 'domingo']
>>> print(list(calendar.day_abbr))
['segunda', 'terça', 'quarta', 'quinta', 'sexta', 'sábado', 'domingo']

This makes the test work in such cases as well.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have some suggestions that reflect the original purpose of the test.

kulikjak and others added 2 commits August 26, 2025 12:38
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@kulikjak
Copy link
Contributor Author

kulikjak commented Aug 26, 2025

Thanks for the suggestions, it's fixed now.

EDIT: and retested, just to be sure ;).

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Thank you for your continued support of Python on Solaris.

@serhiy-storchaka serhiy-storchaka merged commit f60f822 into python:main Aug 26, 2025
49 checks passed
@kulikjak
Copy link
Contributor Author

Thank you for merging my changes 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants