Skip to content

gh-138008: fix segfault in _cyptes during _build_callargs #138166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Draft

gh-138008: fix segfault in _cyptes during _build_callargs #138166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c2b67
gh-138008: fix segfault in _cyptes during _build_callargs
Zheaoli Aug 26, 2025
39cc479
add test and news
Zheaoli Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_ctypes/test_funcptr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ def c_string(init):
def test_abstract(self):
self.assertRaises(TypeError, _CFuncPtr, 13, "name", 42, "iid")

def test_invalid_argtypes(self):
libc = CDLL(None)

PRINTF_PROTO = CFUNCTYPE(c_int, ctypes.c_char_p)
c_printf = PRINTF_PROTO(("printf", libc), ((1,),))
c_printf.argtypes = (c_char_p, c_int)
with self.assertRaises(TypeError):
c_printf(b"Hello\n")

if __name__ == '__main__':
unittest.main()
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-08-27-01-04-38.gh-issue-138008.iCEhZ9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix segfaults in _cyptes during _build_callargs.
6 changes: 5 additions & 1 deletion Modules/_ctypes/_ctypes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4374,7 +4374,11 @@ _build_callargs(ctypes_state *st, PyCFuncPtrObject *self, PyObject *argtypes,
callargs = PyTuple_New(len); /* the argument tuple we build */
if (callargs == NULL)
return NULL;

if (!_validate_paramflags(st, Py_TYPE(self), argtypes)) {
PyErr_SetString(PyExc_TypeError,
"the current argument is invalid");
goto error;
}
#ifdef MS_WIN32
/* For a COM method, skip the first arg */
if (self->index) {
Expand Down
Loading