Skip to content

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 27, 2025

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to run this for Unicode releases, which are roughly once a year. Running this in CI constantly otherwise is wasteful, so I support reverting.

A

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change caused a failure in #138203 due to a timeout downloading the Unicode data, so I support reverting.

@hugovk hugovk merged commit 03f8d3b into python:main Aug 28, 2025
53 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2025
…a part of our CI pythonGH-126682" (pythonGH-138197)

(cherry picked from commit 03f8d3b)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Aug 28, 2025

GH-138218 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 28, 2025
hugovk pushed a commit that referenced this pull request Aug 28, 2025
…t of our CI GH-126682" (GH-138197) (#138218)

gh-126524: Revert "gh-126524: Run `regen-unicodedata` as a part of our CI GH-126682" (GH-138197)
(cherry picked from commit 03f8d3b)

Co-authored-by: sobolevn <mail@sobolevn.me>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…ta` as a part of our CI pythonGH-126682" (pythonGH-138197) (python#138218)

pythongh-126524: Revert "pythongh-126524: Run `regen-unicodedata` as a part of our CI pythonGH-126682" (pythonGH-138197)
(cherry picked from commit 03f8d3b)

Co-authored-by: sobolevn <mail@sobolevn.me>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants