Skip to content

gh-138279: Remove unused attr in RuleCollectorVisitor in parser_generator.py #138280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2025
Merged

gh-138279: Remove unused attr in RuleCollectorVisitor in parser_generator.py #138280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Tools/peg_generator/pegen/parser_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@
class RuleCollectorVisitor(GrammarVisitor):
"""Visitor that invokes a provided callmaker visitor with just the NamedItem nodes"""

def __init__(self, rules: Dict[str, Rule], callmakervisitor: GrammarVisitor) -> None:
self.rules = rules
def __init__(self, callmakervisitor: GrammarVisitor) -> None:
self.callmaker = callmakervisitor

def visit_Rule(self, rule: Rule) -> None:
Expand Down Expand Up @@ -163,7 +162,7 @@ def collect_rules(self) -> None:
for rule in self.all_rules.values():
keyword_collector.visit(rule)

rule_collector = RuleCollectorVisitor(self.rules, self.callmakervisitor)
rule_collector = RuleCollectorVisitor(self.callmakervisitor)
done: Set[str] = set()
while True:
computed_rules = list(self.all_rules)
Expand Down
Loading