Skip to content

gh-138360: Fix test_free_threading for IO objects #138359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

gh-138360: Fix test_free_threading for IO objects #138359

merged 1 commit into from
Sep 1, 2025

Conversation

uhx
Copy link
Contributor

@uhx uhx commented Sep 1, 2025 •
edited by bedevere-app bot
Loading

@python-cla-bot
Copy link

python-cla-bot bot commented Sep 1, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 1, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 1, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@uhx
Copy link
Contributor Author

uhx commented Sep 1, 2025 •
edited
Loading

@Eclips4 please add skip-news label & review

@picnixz picnixz changed the title Fix typo in test_io.py Fix test_free_threading for IO objects Sep 1, 2025
@picnixz
Copy link
Member

picnixz commented Sep 1, 2025 •
edited
Loading

I think it would make sense to have an issue, just for backports tracking. I'll create one.

@picnixz picnixz changed the title Fix test_free_threading for IO objects gh-138360: Fix test_free_threading for IO objects Sep 1, 2025
@bedevere-app bedevere-app bot mentioned this pull request Sep 1, 2025
Closed
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 1, 2025
@uhx
Copy link
Contributor Author

uhx commented Sep 1, 2025

@picnixz thanks a lot

@Eclips4
Copy link
Member

Eclips4 commented Sep 1, 2025

@picnixz I don't think that we need any test case here. What do you think?

@sobolevn sobolevn enabled auto-merge (squash) September 1, 2025 19:37
@picnixz
Copy link
Member

picnixz commented Sep 1, 2025

I don't think that we need any test case here. What do you think?

Err, no? this PR is fine!

@sobolevn sobolevn merged commit 7c92497 into python:main Sep 1, 2025
57 checks passed
@miss-islington-app
Copy link

Thanks @uhx for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @uhx and @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7c92497e5c6d3d6c36721f554d09efffbe4bbc23 3.14

@miss-islington-app
Copy link

Sorry, @uhx and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7c92497e5c6d3d6c36721f554d09efffbe4bbc23 3.13

@picnixz
Copy link
Member

picnixz commented Sep 2, 2025

@uhx Could you take care of the backports please? you'll need to find the tests (they could have moved somewhere else)

@uhx
Copy link
Contributor Author

uhx commented Sep 2, 2025

@picnixz sure thing, I took a quick look at it yesterday but didn't find anything.

I checked the PR that introduced this test and noticed that this change was not included into 3.14:

I also couldn't find these changes in any of the versions (3.13, 3.14)

@picnixz
Copy link
Member

picnixz commented Sep 2, 2025 •
edited
Loading

Oh so they were only 3.15+, no need for backports for now! Thank for having a look. However, I think #132616 should have been backported as it's a bugfix IMO.

lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@uhx @lkollar
pythongh-138360: Fix test_free_threading for IO objects (python#138359
affc9b0 
)

Fix typo in test_io.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@sobolevn sobolevn sobolevn approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees

@sobolevn sobolevn

Labels
needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uhx @picnixz @Eclips4 @colesbury @sobolevn