-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Add class directives for xml.dom
#138419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class directives for xml.dom
#138419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have great doubts about these changes. Because all these classes are not defined in the xml.dom
module. This is not description of concrete classes, this is description of ephemeral interfaces. Concrete classes are defined in the minidom
submodule and in third-party modules. Adding class
directives here will create wrong index entries and add wrong user visible information.
Try to add :no-typesetting:
and :no-index-entry:
options. Not sure about :no-contents-entry:
. Will this be of any benefit?
Sphinx doesn't have a I think it would be useful to add them, but I'm happy to revert to just adding the targets if you still have reservations. A |
User should not see It would be nice to make some class references referring to corresponding section in this file, for example, Before we find a satisfying solution, it is better to leave unresolved references as a reminder. |
Ok, I will close this for now & we can revisit it later, I will make a smaller change to #138418. A |
Required for #138418.
A
📚 Documentation preview 📚: https://cpython-previews--138419.org.readthedocs.build/