Skip to content

gh-116738: test dbm.gnu module on FT Python build #138467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2025
Merged

gh-116738: test dbm.gnu module on FT Python build #138467

merged 2 commits into from
Oct 12, 2025
+79 −0

Conversation

yoney
Copy link
Contributor

@yoney yoney commented Sep 3, 2025 •
edited
Loading

#132749 added critical sections to the gnu.dbm object. This PR introduces multi-threaded tests for the dbm.gnu module.

cc: @mpage @colesbury @Yhg1s

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Sep 3, 2025
@bedevere-app bedevere-app bot mentioned this pull request Sep 3, 2025
Open
@yoney yoney marked this pull request as ready for review September 3, 2025 18:15
@mpage mpage requested review from Yhg1s, colesbury and mpage September 4, 2025 17:04
@mpage mpage added the skip news label Sep 4, 2025
@kumaraditya303 kumaraditya303 changed the title gh-116738: Test mdb.gnu module on FT Python build gh-116738: test dbm.gnu module on FT Python build Oct 2, 2025
@kumaraditya303 kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Oct 11, 2025
kumaraditya303
kumaraditya303 reviewed Oct 11, 2025
View reviewed changes
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 9a1c8ae 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138467%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2025
@kumaraditya303 kumaraditya303 merged commit a18843d into python:main Oct 12, 2025
110 of 114 checks passed
@miss-islington-app
Copy link

Thanks @yoney for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2025
@yoney @miss-islington
pythongh-116738: test dbm.gnu module on FT Python build (pythonGH-1…
916066c 
…38467)

(cherry picked from commit a18843d)

Co-authored-by: Alper <alperyoney@fb.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 12, 2025

GH-139987 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@colesbury colesbury Awaiting requested review from colesbury

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

@mpage mpage Awaiting requested review from mpage

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoney @bedevere-bot @kumaraditya303 @mpage