bpo-37166: inspect.findsource() no longer triggers IndexError... #13850
Conversation
Misc/NEWS.d/next/Library/2019-06-05-14-47-06.bpo-37166.cDr9zg.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
|
@vstinner: would you mind taking a look? |
I have a question: https://bugs.python.org/issue37166#msg345922 |
|
I believe @mibpl answered the questions on the bug tracker. |
|
Sorry, I'm unavailable to review this PR. |
|
@1st1 would you have time to take a look? I'm afraid I'm not familiar enough with this code. |
|
@mibpl Do you think we can add a test for this? |
|
@1st1 Sure, would this one be sufficient? 683a2d6 See this comment on why it was removed, I'm happy to bring it back: #13850 (comment) |
mibpl
requested review from
1st1,
abalkin,
asvetlov and
berkerpeksag
as code owners
zware
removed request for
gpshead,
vsajip,
vstinner,
methane,
warsaw,
encukou,
asvetlov,
tiran,
ericvsmith,
abalkin,
ncoghlan,
ericsnowcurrently,
pganssle,
rhettinger,
gvanrossum,
ethanfurman,
pablogsal,
ilevkivskyi,
skrah,
terryjreedy and
ezio-melotti
…is larger then the size of the linecache entry
This reverts commit 093f93945702f64c95865dc4283cfb8d8427f469.
|
Closing the PR following the closure of its b.p.o issue (https://bugs.python.org/issue37166) |
...when co_firstlineno is larger than the size of the linecache entry
https://bugs.python.org/issue37166