Skip to content

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Sep 4, 2025

  • KeyError is not raised for defaultdict, use an explicit test
  • Fix relative paths on different drives on Windows
  • Add a round-trip test

* KeyError is not raised for defaultdict
* Fix relative paths on different drives on Windows
* Add a round-trip test
@AA-Turner AA-Turner requested review from itamaro and FFY00 September 4, 2025 19:53
@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label Sep 4, 2025
@AA-Turner AA-Turner changed the title gh-136264: Fix `--relative-paths for PEP 739's build-details.json gh-136264: Fix --relative-paths for PEP 739's build-details.json Sep 4, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Sep 4, 2025
Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI is unhappy

Co-authored-by: Itamar Oren <itamarost@gmail.com>
@AA-Turner AA-Turner requested a review from itamaro September 8, 2025 00:07
@AA-Turner AA-Turner merged commit 057ee17 into python:main Sep 8, 2025
51 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2025
….json (pythonGH-138510)

* KeyError is not raised for defaultdict
* Fix relative paths on different drives on Windows
* Add a round-trip test
(cherry picked from commit 057ee1741015067b46446e46eab467c1fa82610d)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Itamar Oren <itamarost@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 8, 2025

GH-138638 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 8, 2025
@AA-Turner AA-Turner deleted the pep739-relative-paths branch September 8, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants