Skip to content

gh-138515: Include email module in Emscripten build #138520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

gh-138515: Include email module in Emscripten build #138520

merged 2 commits into from
Sep 5, 2025

Conversation

ryanking13
Copy link
Contributor

@ryanking13 ryanking13 commented Sep 5, 2025 •
edited by bedevere-app bot
Loading

One line change to include the email module in the Emscripten build so the importlib.metadata package can be imported without an error.

@bedevere-app bedevere-app bot mentioned this pull request Sep 5, 2025
Closed
@hoodmane
Copy link
Contributor

hoodmane commented Sep 5, 2025

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 1acd7e1 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138520%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

corona10
corona10 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I direclty talked with @ryanking13 that including email again makes Emscripten build situation better, and nothing will affect the CPython itself at this moment.

@corona10
Copy link
Member

corona10 commented Sep 5, 2025

@ryanking13 Please add NEWS.d that you included this package again,

@corona10 corona10 enabled auto-merge (squash) September 5, 2025 07:50
@corona10 corona10 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 5, 2025
@ryanking13
Copy link
Contributor Author

@corona10 yup, added it.

@corona10 corona10 disabled auto-merge September 5, 2025 08:03
@corona10
Copy link
Member

corona10 commented Sep 5, 2025

Let me check emcrypten build bot test also :)

@corona10
Copy link
Member

corona10 commented Sep 5, 2025

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @corona10 for commit e74afa1 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138520%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@corona10 corona10 merged commit d1d8409 into python:main Sep 5, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @ryanking13 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2025
@ryanking13 @miss-islington
pythongh-138515: Include email module in Emscripten build (pythongh-1…
f75a788 
…38520)

(cherry picked from commit d1d8409)

Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2025
@ryanking13 @miss-islington
pythongh-138515: Include email module in Emscripten build (pythongh-1…
c2e44ed 
…38520)

(cherry picked from commit d1d8409)

Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2025

GH-138533 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2025

GH-138534 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 5, 2025
corona10 pushed a commit that referenced this pull request Sep 5, 2025
@miss-islington @ryanking13
[3.13] gh-138515: Include email module in Emscripten build (gh-138520) (
5f61a0a 
gh-138534)

gh-138515: Include email module in Emscripten build (gh-138520)
(cherry picked from commit d1d8409)

Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
hugovk pushed a commit that referenced this pull request Sep 5, 2025
@miss-islington @ryanking13
[3.14] gh-138515: Include email module in Emscripten build (gh-138520) (
09f1eff 
#138533)

Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @ryanking13 @kumaraditya303
[3.14] pythongh-138515: Include email module in Emscripten build (pyt…
4f85e05 
…hongh-138520) (python#138533)

Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@ryanking13 @lkollar
pythongh-138515: Include email module in Emscripten build (pythongh-1…
cc14494 
…38520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@hoodmane hoodmane hoodmane approved these changes

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742 freakboy3742 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanking13 @hoodmane @bedevere-bot @corona10