gh-137210: Move PYTHON_API_VERSION & PYTHON_ABI_VERSION to patchlevel.h #138545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows removing #include "modsupport.h" from python_ver_rc.h, which allows modsupport.h to use common helpers from Python.h -- specifically, `_Py_PACK_VERSION` for defining limited API.
|
macOS 13 failing with the below, seems unrelated. |
AA-Turner
approved these changes
Sep 6, 2025
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…hlevel.h (pythonGH-138545) Move PYTHON_API_VERSION & PYTHON_ABI_VERSION to patchlevel.h This allows removing #include "modsupport.h" from python_ver_rc.h, which allows modsupport.h to use common helpers from Python.h -- specifically, `_Py_PACK_VERSION` for defining limited API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows removing #include "modsupport.h" from python_ver_rc.h, which allows modsupport.h to use common helpers from Python.h -- specifically,
_Py_PACK_VERSIONfor defining limited API.