Skip to content

gh-130567: Fix crash in locale.strxfrm() on macOS #138615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-130567: Fix crash in locale.strxfrm() on macOS #138615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c904e7
gh-130567: Fix crash in locale.strxfrm() on macOS
serhiy-storchaka Sep 7, 2025
c32fa1f
Use 'Gwichʼin' in tests.
serhiy-storchaka Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/test/test_locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,7 @@ def setUp(self):
enc = codecs.lookup(locale.getencoding() or 'ascii').name
if enc not in ('utf-8', 'iso8859-1', 'cp1252'):
raise unittest.SkipTest('encoding not suitable')
if enc != 'iso8859-1' and (sys.platform == 'darwin' or is_android or
sys.platform.startswith('freebsd')):
if enc != 'iso8859-1' and is_android:
raise unittest.SkipTest('wcscoll/wcsxfrm have known bugs')
BaseLocalizedTest.setUp(self)

Expand All @@ -371,6 +370,8 @@ def test_strcoll_with_diacritic(self):
"gh-124108: NetBSD doesn't support UTF-8 for LC_COLLATE")
def test_strxfrm_with_diacritic(self):
self.assertLess(locale.strxfrm('à'), locale.strxfrm('b'))
# gh-130567: Should not crash on macOS.
locale.strxfrm('Gwich\u02bcin')


class NormalizeTest(unittest.TestCase):
Expand Down
Loading