gh-138661: fix data race in PyCode_Addr2Line

[kumaraditya303]

• Issue: data race in PyCode_Addr2Line #138661

[mpage]

The fix looks good to me, but it looks like test_faulthandler is timing out on the free-threaded builds.

[bedevere-app]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[vstinner]

The fix looks good to me, but it looks like test_faulthandler is timing out on the free-threaded builds.

faulthandler calls dump_frame() which calls PyUnstable_InterpreterFrame_GetLine() which calls PyCode_Addr2Line(). faulthandler can be triggered without holding the GIL (without having an attached thread state).

[vstinner]

Maybe faulthandler should use an internal API which avoids the critical section. Such API should be added if it doesn't exist yet.

[kumaraditya303]

faulthandler calls dump_frame() which calls PyUnstable_InterpreterFrame_GetLine() which calls PyCode_Addr2Line(). faulthandler can be triggered without holding the GIL (without having an attached thread state).

Thanks for the pointer, I have fixed it now by adding an internal API which would work without attached tstate.

[vstinner]

LGTM

fixed the test_faulthandler issue

[miss-islington-app]

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[bedevere-app]

GH-138834 is a backport of this pull request to the 3.14 branch.