gh-138577: Mention limitations of getpass.getpass(echo_char=...)
#138677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
picnixz
changed the title
getpass.getpass(echo_char=...)
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
picnixz
reviewed
Sep 8, 2025
|
Thank you for the fix! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…s(echo_char=...)` (pythonGH-138677) In bf8bbe9, `getpass.getpass` gained the ability to provide keyboard feedback through `echo_char`. On Unix, line editing shortcuts such as Ctrl+U were previously handled as the terminal operates in canonical mode (see termios(3)). However, since keyboard feedback requires to switch to noncanonical mode, this now results in an inconsistency when `getpass.getpass` uses `echo_char` as those shortcuts are no more supported. This limitation is specific to Unix and does not affect Windows users where line editing shortcuts were never supported. (cherry picked from commit 074f3b2) Co-authored-by: yagggi <fakepoet0101@gmail.com>
|
GH-138696 is a backport of this pull request to the 3.14 branch. |
hugovk
pushed a commit
that referenced
this pull request
Sep 9, 2025
|
Thanks @picnixz for your patience and guidance, glad to do something to CPython. |
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…s(echo_char=...)` (python#138677) In bf8bbe9, `getpass.getpass` gained the ability to provide keyboard feedback through `echo_char`. On Unix, line editing shortcuts such as Ctrl+U were previously handled as the terminal operates in canonical mode (see termios(3)). However, since keyboard feedback requires to switch to noncanonical mode, this now results in an inconsistency when `getpass.getpass` uses `echo_char` as those shortcuts are no more supported. This limitation is specific to Unix and does not affect Windows users where line editing shortcuts were never supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getpass'secho_charshould not affect keyboard shortcuts #138577📚 Documentation preview 📚: https://cpython-previews--138677.org.readthedocs.build/