gh-138712: Add os.NODEV #138728
gh-138712: Add os.NODEV #138728
Conversation
serhiy-storchaka
force-pushed
the
os-NODEV
branch
from
7063cfd to
2ba5b75
Compare
There was a problem hiding this comment.
Can you document the new constant in https://docs.python.org/dev/whatsnew/3.15.html#improved-modules ?
| .. data:: NODEV | ||
|
|
||
| Non-existent device. | ||
|
|
There was a problem hiding this comment.
Would you mind to add a .. versionadded:: next markup?
There was a problem hiding this comment.
Oh, I missed this? Thank you for noticing.
| if (hasattr(posix, 'NODEV') and | ||
| sys.platform.startswith(('linux', 'macos', 'freebsd', 'dragonfly', | ||
| 'sunos'))): | ||
| NODEV = posix.NODEV |
There was a problem hiding this comment.
Is this code path still skipped on Alpine Linux (musl)?
There was a problem hiding this comment.
It is skipped if NODEV is not defined in musl. But if it is defined, the following tests will fail, so we will need to add an additional condition.
| .. data:: NODEV | ||
|
|
||
| Non-existent device. | ||
|
|
There was a problem hiding this comment.
Oh, I missed this? Thank you for noticing.
| if (hasattr(posix, 'NODEV') and | ||
| sys.platform.startswith(('linux', 'macos', 'freebsd', 'dragonfly', | ||
| 'sunos'))): | ||
| NODEV = posix.NODEV |
There was a problem hiding this comment.
It is skipped if NODEV is not defined in musl. But if it is defined, the following tests will fail, so we will need to add an additional condition.
|
!buildbot alpine |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2ba5b75 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138728%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
📚 Documentation preview 📚: https://cpython-previews--138728.org.readthedocs.build/