-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-138744: GitHub Actions: pin to windows-2022
#138743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
windows-22.04
windows-22.04
Also needed in |
windows-22.04
windows-2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's a good idea to pin the Windows version and only upgrade it once it's well tested on newer Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Pinning is a good idea in any case.
Question: does this new version have os.getpid
?
Looks like they both do: |
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13, 3.14. |
(cherry picked from commit 6e78a53) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sorry, @hugovk, I could not cleanly backport this to
|
Sorry, @hugovk, I could not cleanly backport this to
|
GH-138752 is a backport of this pull request to the 3.14 branch. |
Sorry, @hugovk, I could not cleanly backport this to
|
Sorry, @hugovk, I could not cleanly backport this to
|
Sorry, @hugovk, I could not cleanly backport this to
|
GH-138753 is a backport of this pull request to the 3.13 branch. |
…GH-138743) (cherry picked from commit 6e78a53) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…GH-138743) (cherry picked from commit 6e78a53) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-138754 is a backport of this pull request to the 3.12 branch. |
…GH-138743) (cherry picked from commit 6e78a53) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-138755 is a backport of this pull request to the 3.11 branch. |
…GH-138743) (cherry picked from commit 6e78a53) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-138757 is a backport of this pull request to the 3.10 branch. |
GH-138758 is a backport of this pull request to the 3.9 branch. |
…138752) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GitHub Actions is in the process of migrating
windows-latest
fromwindows-2022
towindows-2025
:actions/runner-images#12677
This is causing failures for forks which have already been migrated, for example:
https://github.com/picnixz/cpython/actions/runs/17610564159/job/50031376950#step:1:9
Upstream and my fork are still on 2022, but let's pin to
windows-2022
so we can separately investigate and fix for 2025, and then pin towindows-2025
.test_dtrace
fails on Windows Server 2025 #138744