GH-138355: Remove trash_delete_later and trash_delete_nesting from _gc_runtime_state #138767

sergey-miryanov · 2025-09-10T18:51:32Z

Both fields are not used anymore. Instead, trashcan mechanism uses tstate->delete_later.

Issue: Remove needless trash_delete_later and trash_delete_nesting fields in _gc_runtime_state #138355

…tate

sergey-miryanov · 2025-09-10T18:53:40Z

They are internal fields. PyInterpreterState and PyThreadState both are opaque. So, I believe this can skip news.

bedevere-bot · 2025-09-11T08:12:55Z

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit dff746f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138767%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

sergey-miryanov · 2025-09-12T06:48:08Z

It seems OK for all buildbots.

vstinner · 2025-09-16T22:21:21Z

Include/cpython/pystate.h

    unsigned long native_thread_id;

+    /* List of objects that still need to be cleaned up, singly linked
+     * via their gc headers' gc_next pointers.  */


You may mention _PyTrash_thread_deposit_object().

@vstinner Please take a look.

vstinner

LGTM

vstinner · 2025-09-17T20:26:14Z

Merged, thank you.

bedevere-bot · 2025-09-17T20:52:33Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x (tier-3) has failed when building commit b42af37.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/567/builds/10144) and take a look at the build logs.
Check if the failure is related to this commit (b42af37) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/567/builds/10144

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.BufferedWriter>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
k

bedevere-bot · 2025-09-17T22:04:15Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.x (tier-3) has failed when building commit b42af37.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1613/builds/2015) and take a look at the build logs.
Check if the failure is related to this commit (b42af37) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1613/builds/2015

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 837, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 25427), raddr=('127.0.0.1', 25428)>
Task was destroyed but it is pending!
task: <Task pending name='Task-1035' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x842e88890>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 837, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('127.0.0.1', 25385), raddr=('127.0.0.1', 25386)>
Task was destroyed but it is pending!
task: <Task pending name='Task-803' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x842e88890>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=10>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 837, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 38584), raddr=('127.0.0.1', 38585)>
Task was destroyed but it is pending!
task: <Task pending name='Task-1972' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x847218890>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k

sergey-miryanov · 2025-09-18T05:37:40Z

Thanks all!

sergey-miryanov added 2 commits September 10, 2025 23:49

Remove trash_delete_later and trash_delete_nesting from _gc_runtime_s…

80eeee9

…tate

Add comments for delete_later from _ts

dff746f

sergey-miryanov requested review from ericsnowcurrently and ZeroIntensity as code owners September 10, 2025 18:51

bedevere-app bot added the awaiting review label Sep 10, 2025

bedevere-app bot mentioned this pull request Sep 10, 2025

Remove needless trash_delete_later and trash_delete_nesting fields in _gc_runtime_state #138355

Closed

sobolevn added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Sep 11, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 11, 2025

sobolevn approved these changes Sep 12, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Sep 12, 2025

vstinner reviewed Sep 16, 2025

View reviewed changes

sergey-miryanov added 2 commits September 17, 2025 22:03

Mention _PyTrash_thread_deposit_object and _PyTrash_thread_destroy_chain

78af3bd

Merge branch 'main' into pythongh-138355-remove-trash-delete-fields

9f027bc

vstinner approved these changes Sep 17, 2025

View reviewed changes

vstinner merged commit b42af37 into python:main Sep 17, 2025
43 checks passed

bedevere-app bot removed the awaiting merge label Sep 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

GH-138355: Remove trash_delete_later and trash_delete_nesting from _gc_runtime_state #138767

GH-138355: Remove trash_delete_later and trash_delete_nesting from _gc_runtime_state #138767

Uh oh!

sergey-miryanov commented Sep 10, 2025 •

edited

Loading

Uh oh!

sergey-miryanov commented Sep 10, 2025

Uh oh!

bedevere-bot commented Sep 11, 2025

Uh oh!

sergey-miryanov commented Sep 12, 2025

Uh oh!

vstinner Sep 16, 2025

Uh oh!

sergey-miryanov Sep 17, 2025

Uh oh!

vstinner left a comment

Uh oh!

Uh oh!

vstinner commented Sep 17, 2025

Uh oh!

bedevere-bot commented Sep 17, 2025

Uh oh!

bedevere-bot commented Sep 17, 2025

Uh oh!

sergey-miryanov commented Sep 18, 2025

Uh oh!

Uh oh!

Uh oh!

GH-138355: Remove trash_delete_later and trash_delete_nesting from _gc_runtime_state #138767

GH-138355: Remove trash_delete_later and trash_delete_nesting from _gc_runtime_state #138767

Uh oh!

Conversation

sergey-miryanov commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergey-miryanov commented Sep 10, 2025

Uh oh!

bedevere-bot commented Sep 11, 2025

Uh oh!

sergey-miryanov commented Sep 12, 2025

Uh oh!

vstinner Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

sergey-miryanov Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vstinner commented Sep 17, 2025

Uh oh!

bedevere-bot commented Sep 17, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 17, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

sergey-miryanov commented Sep 18, 2025

Uh oh!

Uh oh!

sergey-miryanov commented Sep 10, 2025 •

edited

Loading