Skip to content

gh-138801: pyrepl tests on Windows aren't executed anymore #138802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

gh-138801: pyrepl tests on Windows aren't executed anymore #138802

merged 3 commits into from
Sep 12, 2025

Conversation

chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Sep 11, 2025 •
edited by bedevere-app bot
Loading

Since #136758 the pyrepl tests are skipped due to

test_pyrepl skipped -- termios required

see e.g. https://github.com/python/cpython/actions/runs/17614938779/job/50045564781#step:6:192.

With this PR applied, running python -m test test_pyrepl I get

Running Release|x64 interpreter...
Using random seed: 3290436162
0:00:00 Run 1 test sequentially in a single process
0:00:00 [1/1] test_pyrepl
0:00:02 [1/1] test_pyrepl passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 2.2 sec
Total tests: run=238 skipped=48
Total test files: run=1/1
Result: SUCCESS

I think this is a skip news?

@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2025
Closed
@chris-eibl chris-eibl added tests Tests in the Lib/test dir OS-windows skip news labels Sep 11, 2025
@StanFromIreland StanFromIreland added the needs backport to 3.14 bugs and security fixes label Sep 11, 2025
@pablogsal
Copy link
Member

Thanks for the fix @chris-eibl ❤️

sobolevn
sobolevn reviewed Sep 11, 2025
View reviewed changes
@sobolevn sobolevn merged commit 4f3cab9 into python:main Sep 12, 2025
43 checks passed
@miss-islington-app
Copy link

Thanks @chris-eibl for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2025
@chris-eibl @miss-islington
pythongh-138801: re-enable pyrepl tests on Windows (pythonGH-138802)
d9d3688 
(cherry picked from commit 4f3cab9)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2025

GH-138815 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 12, 2025
@chris-eibl chris-eibl deleted the fix_pyrepl_tests_win branch September 13, 2025 14:02
ambv pushed a commit that referenced this pull request Sep 15, 2025
@miss-islington @chris-eibl
[3.14] gh-138801: re-enable pyrepl tests on Windows (GH-138802) (GH…
19a8670 
…-138815)

gh-138801: re-enable `pyrepl` tests on Windows (GH-138802)
(cherry picked from commit 4f3cab9)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@emmatyping emmatyping emmatyping approved these changes

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
OS-windows skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chris-eibl @pablogsal @sobolevn @emmatyping @StanFromIreland