gh-138813: Fix mutable default kwargs={} in multiprocessing BaseProcess and DummyProcess to use None #138814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
The core change looks good to me, but please add a test case to test_multiprocessing.
gpshead
approved these changes
Sep 12, 2025
zeff-ir
force-pushed
the
gh-138813-fix-dummyprocess-kwargs
branch
from
d83c952 to
913e868
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@ZeroIntensity, I’ve addressed your comment, please take another look. |
gpshead
reviewed
Sep 14, 2025
Misc/NEWS.d/next/Library/2025-09-13-15-31-09.gh-issue-138813.1k7qT6.rst
Outdated
Show resolved
Hide resolved
zeff-ir
force-pushed
the
gh-138813-fix-dummyprocess-kwargs
branch
from
34a699f to
1c9fd45
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Misc/NEWS.d/next/Library/2025-09-15-07-02-26.gh-issue-138813.yIju93.rst
Outdated
Show resolved
Hide resolved
zeff-ir
force-pushed
the
gh-138813-fix-dummyprocess-kwargs
branch
from
d7b6b49 to
26da571
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Added the test in the latest commit. |
zeff-ir
force-pushed
the
gh-138813-fix-dummyprocess-kwargs
branch
from
0489a60 to
820a48d
Compare
zeff-ir
force-pushed
the
gh-138813-fix-dummyprocess-kwargs
branch
from
dfa3806 to
b6f292f
Compare
gpshead
approved these changes
Sep 17, 2025
gpshead
changed the title
gpshead
added
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2025
…eProcess and DummyProcess to use None (pythonGH-138814) * pythongh-138813: Default `BaseProcess` `kwargs` to `None` (pythonGH-138814) Set `BaseProcess.__init__(..., kwargs=None)` and initialize `kwargs` with `dict(kwargs) if kwargs else {}`. This avoids a shared mutable default and matches threading.Thread behavior. Co-authored-by: Dmitrii Chuprov <cheese@altlinux.org> * DummyProcess kwargs=None (which threading.Thread accepts properly) (cherry picked from commit 5a15e73) Co-authored-by: Denis Sergeev <newjimbatler00@gmail.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2025
…eProcess and DummyProcess to use None (pythonGH-138814) * pythongh-138813: Default `BaseProcess` `kwargs` to `None` (pythonGH-138814) Set `BaseProcess.__init__(..., kwargs=None)` and initialize `kwargs` with `dict(kwargs) if kwargs else {}`. This avoids a shared mutable default and matches threading.Thread behavior. Co-authored-by: Dmitrii Chuprov <cheese@altlinux.org> * DummyProcess kwargs=None (which threading.Thread accepts properly) (cherry picked from commit 5a15e73) Co-authored-by: Denis Sergeev <newjimbatler00@gmail.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-139083 is a backport of this pull request to the 3.13 branch. |
|
GH-139084 is a backport of this pull request to the 3.14 branch. |
|
|
gpshead
added a commit
that referenced
this pull request
Oct 8, 2025
…seProcess and DummyProcess to use None (GH-138814) (#139084) gh-138813: Fix mutable default kwargs={} in multiprocessing BaseProcess and DummyProcess to use None (GH-138814) * gh-138813: Default `BaseProcess` `kwargs` to `None` (GH-138814) Set `BaseProcess.__init__(..., kwargs=None)` and initialize `kwargs` with `dict(kwargs) if kwargs else {}`. This avoids a shared mutable default and matches threading.Thread behavior. * DummyProcess kwargs=None (which threading.Thread accepts properly) (cherry picked from commit 5a15e73) Co-authored-by: Denis Sergeev <newjimbatler00@gmail.com> Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default value of the 'kwargs' parameter in DummyProcess.init() from {} to None to avoid mutable default argument issues. This makes DummyProcess consistent with threading.Thread and threading.Timer which already use this pattern.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Reported by: Dmitrii Chuprov cheese@altlinux.org
multiprocessing.dummy.DummyProcess.__init__#138813